fix(bump): extract option validation and new version resolution #1646
+82
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearomorphism
requested review from
Lee-W,
noirbizarre and
woile
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-10-1 #1646 +/- ##
==========================================
Coverage ? 98.68%
==========================================
Files ? 60
Lines ? 2656
Branches ? 0
==========================================
Hits ? 2621
Misses ? 35
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
changed the title
Lee-W
reviewed
Nov 16, 2025
Lee-W
changed the title
Lee-W
reviewed
Nov 18, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
mostly good. one minor question
|
|
||
| if build_metadata and is_local_version: | ||
| raise NotAllowed("--local-version cannot be combined with --build-metadata") | ||
| # we create an empty PATCH increment for empty tag |
Member
There was a problem hiding this comment.
Not sure whehter we documented this. If not, we should add it 🤔 but we could do that in the future
|
|
||
|
|
||
| @pytest.mark.usefixtures("tmp_commitizen_project") | ||
| def test_bump_get_next__manual_version_is_not_allowed(mocker: MockFixture): |
Contributor
Author
Member
There was a problem hiding this comment.
one nit on that one. and than I think we're good to merge both
Lee-W
added
pr-status: ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Relate #1643
NotAllowederror messages and raise it at the end of option validation process